Closed ethanhs closed 9 years ago
Looks good @IronManMark20
The next thing we need to figure out is how to get this update to PyPI, as the latest commit is for 5.4 which is too large for PyPI, so we'll need to merge this pull-request with this commit and create a new release for that.
Possibly as a separate branch, to keep it separate.
We could also merge it with the latest commit, and keep the installation on GitHub-only.
What are your thoughts?
I think people who are told to pip install python-qt5
won't necessarily know that the binaries are Windows only. What that means for the project is beyond me.
I'm with you, it makes sense.
I made a new branch where your fix would make the most sense, could you re-target your pull-request to the branch 5.3? There should be a drop-down at the top of either this page, or when you first make the pull-request.
We'll merge it there, and I'll get this up to PyPI.
Hmm.. no luck re-aiming a PR doesn't seem to be possible. -_- I'll just open a new one.
I added the solution as discussed here