pyr / cyanite

cyanite stores your metrics
http://cyanite.io
Other
446 stars 79 forks source link

Make processing queue single-treaded to ensure event ordering #192

Closed ifesdjeen closed 8 years ago

ifesdjeen commented 8 years ago

This is a first step towards being able to enable event processing without atoms, with volatile objects.

pyr commented 8 years ago

Do you think we will get any improvements from this versus many threads acting on an atom?

ifesdjeen commented 8 years ago

TBH I mostly care about order at that point :) so no, I don't think that switching to volatile is that important right now.

Ordering wouldn't be a big deal in the non-contended environment, either, but given two updates for the atom pending in the queue, they can be processed out of order. Although after thinking about it once again I'm not sure if that one is that bad / important either since all the operations are commutative :/

ifesdjeen commented 8 years ago

Closing as irrelevant then.