search

pyr / cyanite

cyanite stores your metrics
http://cyanite.io
Other
446 stars 79 forks source link

Feature/expose min max #248

Closed ifesdjeen closed 7 years ago

ifesdjeen commented 7 years ago

This is a (very rough) prototype of metric multiplexing, that would allow us to close #244.

I've implemented those "virtual metrics", such as you see on the screenshot:

screen shot 2016-10-02 at 22 01 47

Note that we're just exposing the metrics that were previously available from Cassandra, but were not exposed in any way (we were almost making a shortcut to mean and the rest of metrics were just hidden).

Please note that currently tests are not yet passing and branch is not very stable. I just wanted to chat about the idea with @pyr and @tehlers320 before I proceed with it further. If you have alternative syntax (or a different idea alltogether), I'm open for suggestions.

ifesdjeen commented 7 years ago

For now, at least tests are working. Might be still rough at the corners. Also, I'd still work to improve the code a bit.

pyr commented 7 years ago

This seems like a fine fine for now. ideally we could pass the agg= parameter from grafana, but that would require building a cyanite plugin in grafana, let's do that once we don't need graphite-api anymore.

ifesdjeen commented 7 years ago

Right. For that we would need to have more complete set of aggregate functions, right?

ifesdjeen commented 7 years ago

I'm quite happy with current PR state, so I'd merge it and move to index problem over the weekend.