Feature/customized decoder

pyr / riemann-kafka

kafka producer and consumer support in riemann

Other

41 stars 14 forks source link

Feature/customized decoder #7

Closed weichuliu closed 8 years ago

weichuliu commented 8 years ago

Make kafka-consumer support :decoder attribute, which should be a customized function that decode the kafka message and turn it into a sequence of riemann events.

Use case: riemann consuming kafka messages which are JSON instead of protobuf objects

CAFxX commented 8 years ago

pyr commented 8 years ago

Hi @weichuliu, thanks for looking into this. I'm ok except for a few nitpicks, see comments inline.

liuweichu commented 8 years ago

@pyr Hi, thanks for reviewing. I updated the branch:

Rebased master branch
Removed version bumping in project.clj for that I will want to bump the version after customized encoder is also supported (will be in the next PR)
Updated error message according to comment

pyr commented 8 years ago

awesome, thanks @weichuliu