pyr0ball / pyr0piezo

An AVR/ARM based piezoelectric sensor for use in ultra-precise applications
https://docs.pyroballpcbs.com/
Other
71 stars 23 forks source link

Fix clearing stored config on restore #51

Closed foodbandlt closed 4 years ago

foodbandlt commented 4 years ago

Looks like it was picking up the default value for VM_CONST instead of the address. This caused it to read from the actual address on restore, and fail to find a value inside of its acceptable range, causing a complete config wipe.

Good idea on checking the read values! Prevents potentially damaging something, for sure.

loredan commented 4 years ago

How did I miss that? Also, checking read values was actually meant as a means to detect first boot and use default settings instead of whatever was stored in EEPROM before that

pyr0ball commented 4 years ago

@loredan don't feel bad, it got past me as well