pyramidscheme / pyramidtriangles

Software to run the Pyramid Scheme triangles
3 stars 0 forks source link

Feature Broken: Restart On Code Update #11

Open johnemajor opened 5 years ago

johnemajor commented 5 years ago

The old show runner//cherrypy would re-read the code and re-start when edits were made while the show runner was running. Now if a file is changed, the show runner stalls with: [15/Aug/2019:01:17:26] ENGINE Waiting for child threads to terminate... INFO:cherrypy.error:[15/Aug/2019:01:17:26] ENGINE Waiting for child threads to terminate... [15/Aug/2019:01:17:26] ENGINE Waiting for thread sACN sending/sender thread. INFO:cherrypy.error:[15/Aug/2019:01:17:26] ENGINE Waiting for thread sACN sending/sender thread.

This had been a quite useful feature.

sul3n3t commented 5 years ago

Here's a link to the prior show loader.

It wasn't doing anything in particular with file modification times. It was dynamically loading code from a directory, but memoizing the call, so it didn't actually execute very often.

sul3n3t commented 5 years ago

Leaving as another note, this entr command-line tool could trivially restart the process on file change.