solved https://github.com/pyranges/pyranges_1.x/issues/16.
Weird problem. Inside version.py, we had:
__version__ = importlib.metadata.version("pyranges")
which looked for the old pyranges, since the pip package name of the new one is pyranges1 (for now). I replaced with:
__version__ = importlib.metadata.version("pyranges1") # note: update when pyranges1 becomes default
which fixed the problem.
The problem was invisible with add-ons because bwread imports the old pyranges. Effectively, version was reporting the version of the old pyranges installed in the system.
So I asked myself, why do we have bwread, a package that requires the old pyranges, as optional dependency of the new one? Digging a little big, I realized we don't need bwread at all, we actually never import it. We migrated to raw pyBigWig (which was a bwread dependency) some time ago, but only partially, without a proper doctest or example data. Also, we never updated correctly pyproject.toml and some other parts of the code. Now it is fixed
I also bumped version number to make more obvious the difference between old v0 and new v1.
solved https://github.com/pyranges/pyranges_1.x/issues/16. Weird problem. Inside version.py, we had:
__version__ = importlib.metadata.version("pyranges")which looked for the old pyranges, since the pip package name of the new one is pyranges1 (for now). I replaced with:__version__ = importlib.metadata.version("pyranges1") # note: update when pyranges1 becomes defaultwhich fixed the problem.The problem was invisible with add-ons because bwread imports the old pyranges. Effectively, version was reporting the version of the old pyranges installed in the system.
So I asked myself, why do we have bwread, a package that requires the old pyranges, as optional dependency of the new one? Digging a little big, I realized we don't need bwread at all, we actually never import it. We migrated to raw pyBigWig (which was a bwread dependency) some time ago, but only partially, without a proper doctest or example data. Also, we never updated correctly pyproject.toml and some other parts of the code. Now it is fixed
I also bumped version number to make more obvious the difference between old v0 and new v1.