Closed yohanboniface closed 5 years ago
OK, so the issue is that while dealing with with HttpParserError
, we call write
, which assumes request.method
is defined, but if the method part of the request body was invalid, this is not the case.
Ah, given we check for self.request
that means that we parsed enough to call on_message_begin
, which attaches the request to the protocol. But still the error is a HttpParserInvalidMethodError
one (a subclass of HttpParserError
we already catch), so I'm not sure how to reproduce this in the unit tests :/
For the record, we have some funny players in the access_logs: