search

pyrddlgym-project / pyRDDLGym

A toolkit for auto-generation of OpenAI Gym environments from RDDL description files.
https://pyrddlgym.readthedocs.io/
MIT License
68 stars 17 forks source link

Re structure examples #171

Closed ataitler closed 1 year ago

mike-gimelfarb commented 1 year ago

I'll take a look today.

mike-gimelfarb commented 1 year ago

Everything looks good to me. My only question is whether it is ok to have spaces in the domain name in the info file? For example, will this work on the command line ? (I guess it should with quotation marks...)

mike-gimelfarb commented 1 year ago

Go ahead and merge, we can fix this later. I am just glad to get rid of so many files in the main :)

ataitler commented 1 year ago

Oh for sure, It got messy. I also don't think it is much of a problem we do not support a CLI now, it is just parsing of argv...

If we decide to support CLI then we can easily make it compatible.