search

pyrddlgym-project / pyRDDLGym

A toolkit for auto-generation of OpenAI Gym environments from RDDL description files.
https://pyrddlgym.readthedocs.io/
MIT License
68 stars 17 forks source link

NEP 50 adoptation #257

Closed MFaisalZaki closed 2 months ago

MFaisalZaki commented 2 months ago

Hi, I'm trying to run the tutorial example, and I got this error:

Screenshot from 2024-08-22 12-40-43

To reproduce:

import pyRDDLGym
env = pyRDDLGym.make("Cartpole_Continuous_gym", "0")
ataitler commented 2 months ago

Hi, Can you please share which version of python do have installed?

Ayal

MFaisalZaki commented 2 months ago

It is version 2.0. Screenshot from 2024-08-22 17-06-16

ssanner commented 2 months ago

I believe Ayal was asking about your version of Python, not PyRDDLGym.

In any event, please see the link "pyRDDLGym playground" at the bottom of the following page

https://pyrddlgym-project.github.io/AAAI24-lab

for a Google Colab that can successfully run "Cartpole_Continuous_gym" using the default Colab Python version 3.10.

On Thu, Aug 22, 2024 at 12:06 PM Mustafa Faisal @.***> wrote:

It is version 2.0. Screenshot.from.2024-08-22.17-06-16.png (view on web) https://github.com/user-attachments/assets/4a703c19-7381-4fb7-a68c-55546e6d60a2

— Reply to this email directly, view it on GitHub https://github.com/pyrddlgym-project/pyRDDLGym/issues/257#issuecomment-2305136533, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRA3JF25TVUQJU3NCN46A3ZSYECDAVCNFSM6AAAAABM56TJTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGEZTMNJTGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MFaisalZaki commented 2 months ago

My bad; the Python version I'm running is 3.10.12 inside a virtual environment.

Screenshot from 2024-08-23 10-42-37

ssanner commented 2 months ago

The issue is likely with the numpy version; I note that the working Google Colab example referenced in this thread is using numpy 1.26.4.

In general, I would encourage you to differentiate your installation from the working Google Colab example to understand what package versions are leading to your errors.

When you get it working, we'd appreciate knowing which package version changes were required as this may help other users. Thanks!

On Fri, Aug 23, 2024 at 5:43 AM Mustafa Faisal @.***> wrote:

My bad; the Python version I'm running is 3.10.12 inside a virtual environment.

Screenshot.from.2024-08-23.10-42-37.png (view on web) https://github.com/user-attachments/assets/37af2090-7138-4336-9bbb-34e944f8255c

— Reply to this email directly, view it on GitHub https://github.com/pyrddlgym-project/pyRDDLGym/issues/257#issuecomment-2306713098, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRA3JB3PZDI55TG3ZP2GSDZS373FAVCNFSM6AAAAABM56TJTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWG4YTGMBZHA . You are receiving this because you commented.Message ID: @.***>

MFaisalZaki commented 2 months ago

Hi @ssanner, you are correct. I have changed the numpy version to 1.26.0, which works now. I recommend updating the requirements file to ensure it uses this version.

ataitler commented 2 months ago

Hi @MFaisalZaki, I am glad to hear everything is working now. Yes we are aware of version problems both with numpy and python 3.12.x. We will of course update the requirements file.