search

pyrech / composer-changelogs

:notebook: Display better summary after Composer update
MIT License
589 stars 26 forks source link

Deprecation Notice: strpos(): Passing null to parameter #1 #77

Closed atishgoswami closed 1 year ago

atishgoswami commented 1 year ago

Getting this error on PHP 8.1.6, the module seems to be working as expected

Deprecation Notice: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/vendor/pyrech/composer-changelogs/src/UrlGenerator/GitBasedUrlGenerator.php:33
Deprecation Notice: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/vendor/pyrech/composer-changelogs/src/UrlGenerator/GitBasedUrlGenerator.php:33
Deprecation Notice: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/vendor/pyrech/composer-changelogs/src/UrlGenerator/WordPressUrlGenerator.php:28
pyrech commented 1 year ago

Hello, thanks for the issue.

I will look into it asap (unless someone proposes a fix before :+1:)

pyrech commented 1 year ago

Hi @atishgoswami, I just released 1.8.2 which should fix this notice. Could you report if it works as expected? Thanks

atishgoswami commented 1 year ago

Hello @pyrech,

Thanks for releasing the fix so quickly 😃 I updated the package, the warning are gone now

pyrech commented 1 year ago

Awesome, thanks for the feedback 🙂