pyrevitlabs / pyRevit

Rapid Application Development (RAD) Environment for Autodesk Revit®
http://wiki.pyrevitlabs.io
GNU General Public License v3.0
1.27k stars 331 forks source link

"Generate Revision Report" doesn't include Revisions in Dependent Views #2004

Open RevitIRL opened 9 months ago

RevitIRL commented 9 months ago

Describe the bug Drawing Set > [Revision] > Generate Revision Report Sheet not listed if the view containing the Revision is a Dependent View

To Reproduce Steps to reproduce the behavior:

  1. Create a new model (I used Revit 2019.2.5, no template, Imperial, to check that it wasn't project-specific)
  2. Create a Revision Cloud in the "Level 1" plan view (default is Seq. 1 - Revision 1)
  3. Expand the Project Browser to see the "Level 1" plan
  4. right-click on it > Duplicate View > Duplicate as a Dependent
  5. Create a new Sheet
  6. Place "Level 1 - Dependent 1" on the Sheet
  7. Run pyRevit > Drawing Set > [Revision] > Generate Revision Report
  8. Note that counts are zero (no Sheets listed)
  9. Run pyRevit > Drawing Set > [Revision] > Find All Revised Sheets
  10. Note that it DOES list the Sheet
  11. Place "Level 1" on the Sheet
  12. Run "Generate Revision Report"
  13. Note that it lists the Sheet: 
    Sheet A101: Unnamed
    Revision Count: 1
    Revision Cloud Count: 1
    Revision Numbers: 1

Expected behavior It should list the Sheet when just the Dependent View is placed.

Also (may be related), "Find All Revision Clouds On Views" should NOT list revisions in "parent" Views that are in Dependent Views on Sheets

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Microsoft Windows [Version 10.0.19045.3448]
(c) Microsoft Corporation. All rights reserved.

>pyrevit env
==> Registered Clones (full git repos)
==> Registered Clones (deployed from archive/image)
master | Deploy: "basepublic" | Branch: "master" | Version: "4.8.13.23182+2215" | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master"
==> Attachments
master | Product: "Autodesk Revit 2024" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master"
master | Product: "2023.1.1" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master" 
master | Product: "Autodesk Revit 2022" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master"
master | Product: "Autodesk Revit 2021" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master"
master | Product: "2020.2.7" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master" 
master | Product: "2019.2.5" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master" 
master | Product: "2018.3.3 Security Fix" | Engine: IPY277 (277) | Path: "C:\Users\<username>\AppData\Roaming\pyRevit-Master"
==> Installed Extensions
==> Default Extension Search Path
C:\Users\<username>\AppData\Roaming\pyRevit\Extensions
==> Extension Search Paths
==> Extension Sources - Default
https://github.com/eirannejad/pyRevit/raw/master/extensions/extensions.json
==> Extension Sources - Additional
==> Installed Revits
Autodesk Revit 2024 | Version: 24.1.0.66 | Build: 20230701_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2024\"
2023.1.1 | Version: 23.1.10.4 | Build: 20221122_1550(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2023\"
Autodesk Revit 2022 | Version: 22.1.50.17 | Build: 20230915_1530(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2022\"
Autodesk Revit 2021 | Version: 21.1.90.15 | Build: 20230907_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2021\"
2020.2.7 | Version: 20.2.70.6 | Build: 20220112_1230(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2020\"
2019.2.5 | Version: 19.2.50.16 | Build: 20220111_1110(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2019\"
2018.3.3 Security Fix | Version: 18.3.3.18 | Build: 20190510_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2018\"
==> Running Revit Instances
PID: 84736 | 2019.2.5 | Version: 19.2.50.16 | Build: 20220111_1110(x64) | Language: 0 | Path: "C:\Program Files\Autodesk\Revit 2019"
==> User Environment
Microsoft Windows 10 [Version 10.0.19045]
Executing User: <domain\user>
Active User: <domain\user>
Admin Access: No
%APPDATA%: "C:\Users\<username>\AppData\Roaming"
Latest Installed .Net Framework: 4.8
Installed .Net Target Packs: v3.5 v4.0 v4.5 v4.5.1 v4.5.2 v4.6 v4.6.1 v4.6.2 v4.7 v4.7.1 v4.7.2 v4.8 v4.X
Installed .Net-Core Target Packs: v5.0.400
pyRevit CLI v4.8.13.23182+2215

Additional context Add any other context about the problem here.

KJS-JBED commented 8 months ago

I will be following this issue because I had the same findings in Revit 2022 (22.1.50.17) using PyRevit (4.8.13.23182+2215, IrnoPython 2.7.7) on Windows 11 (22631.2861). I checked the Revision Report after using "Create Revised Sheet Set" created a 2 sheet set that should've had 14 sheets.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 60 days with no activity.

sanzoghenzo commented 5 months ago

bumping this to avoid the automatic closure in 14 days...

Is this still relevant with the last pyrevit version (4.8.14)?

If yes, can you try to hold the CTRL key while clicking on the button? it will show an output log, please copy it and paste it here.