search

pyrevitlabs / pyRevit

Rapid Application Development (RAD) Environment for Autodesk Revit®
http://wiki.pyrevitlabs.io
GNU General Public License v3.0
1.28k stars 331 forks source link

Keynote Manager Compatibility with BIM360 #795

Closed Siversmith closed 3 years ago

Siversmith commented 4 years ago

Good day, we currently have our keynotes saved on to our server in order to use Pyrevit's keynote manager.

We would prefer to actually have this living on BIM 360 but Pyrevit doesn't seem talk with BIM360.

We have tested everything we are aware of and looked here if any others had similar issues but have yet to find anything related to this.

eirannejad commented 4 years ago

Keynote manager is designed to primarily work with the external text files. The issue is that BIM360 cost lots of money and I haven't been able to test the keynote manager on BIM360.

Let me know if you can provide a shared model that I can use to test

Siversmith commented 4 years ago

Will have to see with my company about something like that. The PyRevit tool set is really useful for many different reasons.

Siversmith commented 4 years ago

I have spoken to my line manager and it is currently being discussed. Hopefully will get an answer about this soon.

Dsperry3 commented 4 years ago

2020-03-06 08_55_22-Window I would be interested in hearing the outcome of this. We utilize BIM360 as well and I promote putting the keynote file with the model. I would like to utilize the keynote manager and realize the file can reside on a local store and be fine but would prefer to have it on BIM360.

Siversmith commented 4 years ago

Still no response on my side with regards to this. I would love to be able to give a testing space for this but I don't have the rights to give access to our BIM360.

Architectuur commented 4 years ago

@eirannejad Any update on this? Would love to have the option to use the keynote manager on BIM360. I am getting the same error as Dsperry3 when trying to reference keynote file on BIM360.

eirannejad commented 3 years ago

I got the keynote file access issue resolved. Keynote manager can now read the keynote text file that is synchronized using the Autodesk Desktop Connector. I have learned that this is the way the keynote text file is supposed to be linked to the models.

Who wants to help me test?

Architectuur commented 3 years ago

I have a BIM360 project that I could test this in. Let me know what you need.

eirannejad commented 3 years ago

@Architectuur Thanks. I'll upload an installer here later today so you can install and test

Dsperry3 commented 3 years ago

I have several BIM360 projects I could try and test in. It will take getting IT involved for me since I do not have admin rights to my machine but should be able to make it work.

eirannejad commented 3 years ago

Okay let's do an in-place fix to avoid messing with the admin issues. Download the two files from here and replace (make backups of the originals first) the existing ones in the installation directory. The paths listed here are inside the installation directory so if your pyRevit is installed under %APPDATA%/pyRevit-Master then the full path of api.py would be %APPDATA%/pyRevit-Master/pyrevitlib/pyrevit/api.py

Once replaced, start Revit again and open your model. Open the Keynote Settings (native Revit command) and verify that the keynote file path starts with BIM 360:// and points to a file that is synced to your local machine inside the BIM 360 drive.

Replacement Files.zip

Architectuur commented 3 years ago

I can select the file through BIM360, It tries to convert the file but fails

image

When I place an already converted keynote file on BIM360, that seems to open correctly.

After making a change to the file through the pyRevit Keynote Manager it then redownloads the keynote file from bim360.

image

The redownloading doesn't seem to be a problem and is a pretty quick process.

eirannejad commented 3 years ago

@Architectuur Okay great. The "Download" progress bar seems to be more of a sync process. It seems like the keynote file stays updated and saves the changes.

Architectuur commented 3 years ago

@eirannejad Correct, the changes are saved. I have not tested with other users yet. I will let you know if issues come up with that.

Is there something more I can send you to help fix the conversion issue?

Great work, thank you for implementing this!

Any chance you want to add the edit key function when you roll this out? ;)

eirannejad commented 3 years ago

Yeah I'm planning to add that now that I need to make change to the underlying code. Please test away and let me know if you see other major issues.

Dsperry3 commented 3 years ago

Thanks @eirannejad but I have a new machine and need a full install of pyRevit before I can test. Currently working on a fast deadline but will try to get to this next week.

Siversmith commented 3 years ago

Currently testing this. I get this error when I open it from the BIM360: file.

"This Element does not represent an external file."

eirannejad commented 3 years ago

@Siversmith Did you replace the two files uploaded here?

Siversmith commented 3 years ago

@eirannejad no I didn't. Went ahead and did so after you mentioned it. Once done it gives me another error. I tried to change my pathing for it within the standard process and I can't seem to access bim360 and can only do so within pyRevit. I am thinking that Revit 2019 is the issue and not pyRevit. I would need to test it out on another project that has 2020 or 2021.

eirannejad commented 3 years ago

@Siversmith I'm assuming you have the Autodesk Desktop Connector installed as well right? It'd be great of you can share screenshots of the errors as well

Dsperry3 commented 3 years ago

probably want to make sure your Autodesk Desktop Connector is up to date... It does not automatically update and has been a problem when not everyone on a team has the most current version..... currently 14.1.0.1074

eirannejad commented 3 years ago

I also might have figured out a way to circumvent the ADC's issue of not keeping files always updated. Will publish a new round of fixes soon with this for more testing

Siversmith commented 3 years ago

My connector is definitely up to date. I still think it is a 2019 issue. Haven't been able to open a project yet for 2020 or 2021 yet to see if it is.

eirannejad commented 3 years ago

Implemented and will be pushed with the next version for testing

apsis0215 commented 3 years ago

@eirannejad @Siversmith Would desktop connector work? Use that to Sync Pyrevit with the BIM 360 so others can use that file? or is PyRevit locking out the File?

eirannejad commented 3 years ago

@apsis0215 if the Revit model is linking to a keynote text file in the ADC drive, pyRevit considers that BIM360 and uses the ADC API to sync the file. It does not create locks for that file, instead when a user opens keynote manager with the BIM360 keynote file, pyRevit will ask ADC to lock the file on the server. Locks get free'd when the keynote manager is closed