pyrevitlabs / pyRevit

Rapid Application Development (RAD) Environment for Autodesk Revit®
http://wiki.pyrevitlabs.io
GNU General Public License v3.0
1.3k stars 332 forks source link

Print Sheets Does Not Remove Non-Printable Characters in v4.8.0 #962

Closed jschwobeGROTH closed 4 years ago

jschwobeGROTH commented 4 years ago

Describe the bug

After updating to PyRevit 4.8.0, when using the PyRevit Print Sheets tool, it does not remove the non-printable character after the tool is done and error is produced. Hovering over the tool says that if this happens, "Shift-Click" the tool. Doing this does not fix the issue and produces a pop-up. See Image below and error message below. Tried uninstalling PyRevit and reinstalling, but same behavior.

C:\WINDOWS\system32>pyrevit env
==> Registered Clones (full git repos)
==> Registered Clones (deployed from archive/image)
master | Deploy: "basepublic" | Branch: "master" | Version: "4.8.0" | Path: "C:\Users\jschwobe\AppData\Roaming\pyRevit-Master"
==> Attachments
master | Product: "2021 First Customer Ship" | Engine: 277 | Path: "C:\Users\jschwobe\AppData\Roaming\pyRevit-Master" | Manifest: "C:\Users\jschwobe\AppData\Roaming\Autodesk\Revit\Addins\2021\pyRevit.addin"
master | Product: "2020.2.2" | Engine: 277 | Path: "C:\Users\jschwobe\AppData\Roaming\pyRevit-Master" | Manifest: "C:\Users\jschwobe\AppData\Roaming\Autodesk\Revit\Addins\2020\pyRevit.addin"
master | Product: "2019.2.2 Hotfix" | Engine: 277 | Path: "C:\Users\jschwobe\AppData\Roaming\pyRevit-Master" | Manifest: "C:\Users\jschwobe\AppData\Roaming\Autodesk\Revit\Addins\2019\pyRevit.addin"
master | Product: "2017.2.5 Security Fix" | Engine: 277 | Path: "C:\Users\jschwobe\AppData\Roaming\pyRevit-Master" | Manifest: "C:\Users\jschwobe\AppData\Roaming\Autodesk\Revit\Addins\2017\pyRevit.addin"
master | Product: "2016 Update 7 for R2" | Engine: 277 | Path: "C:\Users\jschwobe\AppData\Roaming\pyRevit-Master" | Manifest: "C:\Users\jschwobe\AppData\Roaming\Autodesk\Revit\Addins\2016\pyRevit.addin"
==> Installed Extensions
==> Default Extension Search Path
C:\Users\jschwobe\AppData\Roaming\pyRevit\Extensions
==> Extension Search Paths
==> Extension Sources - Default
https://github.com/eirannejad/pyRevit/raw/master/extensions/extensions.json
==> Extension Sources - Additional
==> Installed Revits
2021 First Customer Ship | Version: 21.0.0.383 | Build: 20200220_1100(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2021"
2020.2.2 | Version: 20.2.20.31 | Build: 20200426_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2020"
2019.2.2 Hotfix | Version: 19.2.20.24 | Build: 20190808_0900(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2019"
2017.2.5 Security Fix | Version: 17.0.1169.0 | Build: 20190508_0315(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2017"
2016 Update 7 for R2 | Version: 16.0.1185.0 | Build: 20161004_0715(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2016"
==> Running Revit Instances
PID: 18328 | 2019.2.2 Hotfix | Version: 19.2.20.24 | Build: 20190808_0900(x64) | Language: 0 | Path: "C:\Program Files\Autodesk\Revit 2019"
==> User Environment
Microsoft Windows 10 [Version 10.0.18363]
Executing User: GDG-ARCHITECTS\jschwobe
Active User: GDG-ARCHITECTS\jschwobe
Admin Access: No
%APPDATA%: "C:\Users\jschwobe\AppData\Roaming"
Latest Installed .Net Framework: 4.8
No .Net Target Packs are installed.
No .Ne-Core Target Packs are installed.
pyRevit CLI 4.8.0.0

To Reproduce Install PyRevit 4.8.0 and click Print Sheets.

Expected behavior PyRevit should temporarily add non-printable character prefix to sheet number, prints pdf, then removes non-printable character to revert schedule sorting to original. If this does not happen automatically, the tool says to shift-click the tool to manually remove characters.

Screenshots

image

eirannejad commented 4 years ago

Ok I'm gonna fix this next. It's been the most annoying issue and has been bugging me for a while. Bad code I'm pretty sure. Time to kill this 🦟

eirannejad commented 4 years ago

Fixed and will be published with next release