pyrevitlabs / pyRevit

Rapid Application Development (RAD) Environment for Autodesk Revit®
http://wiki.pyrevitlabs.io
GNU General Public License v3.0
1.27k stars 330 forks source link

pyRevit Keynote manager keeps loading forever and then times out.. #967

Closed jashwanthl closed 4 years ago

jashwanthl commented 4 years ago

Describe the bug For many users in our firm the pyRevit keynote manager when clicked starts a never ending loading screen and then eventually timesout or had to be forced stop(when users waited over 30 minutes). All the other tools still work for these users and some of them have new high performance laptops... The tool does work perfectly for some of us but we've spent hours trying to isolate the differences/problems between the computers that the keynote manager tool works and with the ones that the tool doesn't and came up with nothing. We also tried to see if uninstalling all the other addins would work but it still went into an unending load loop for these users. We also tried installing the newest release (the pyRevit 4.8 *thank you) but it did not resolve this issue.

To Reproduce Steps to reproduce the behavior: Click on the keynote manager tool on the pyrevit ribbon.

Expected behavior The keynote manager UI to pop up. But it doesn't even show the initial alert/form to convert the keynote text file to a pyRevit one.

Screenshots It's just a loading screen

Desktop (please complete the following information):

Additional context We greatly appreciate all the tools that you have open sourced and I convinced entire teams to use the pyRevit keynote manager. Everybody loved the tool(from the youtube video) but can't figure out why it doesn't work on their machines... Any help is greatly appreciated

jashwanthl commented 4 years ago

An Update from our tests : When Revit 2020 was updated to version 20.2.20, it started throwing the timeout error. The keynote manager was working for these users before updating and it still works in other versions of Revit. BF5E8F6

eirannejad commented 4 years ago

@jashwanthl Keynote manager creates a lock file (in the same path as the keynote text file with the same name and .lock extension) to tell other Revit instances that it is writing data to the keynote file. This way multiple users won't overwrite each others changes. When the *.lock file exists, the keynote manager will wait for 10 seconds to see if the lock goes away or not. It will return the "Wait for unlock timeout" error if it does not.

With this background, I have a few questions:

jashwanthl commented 4 years ago

@eirannejad Thank you for looking into the problem. The answer to your questions:

Edit: The pyRevit keynote manager works after I delete the lock file.

eirannejad commented 4 years ago

@jashwanthl Okay so we figured out the issue is due to sticky .lock files. There is either a bug or this happens when pyRevit keynote manager crashes. Do you get any crash reports like that from your users? I'd love to know if the keynote manager crashes so I can fix that issue and hopefully resolve the sticky .lock file issue as well

jashwanthl commented 4 years ago

@eirannejad Yes sir! The users haven't been getting any keynote manager crashes anymore (after the lock file was deleted). We haven't been archiving crash reports but if it does happen again I will make sure to get the crash report and post it. Thank you for all your help :)

eirannejad commented 4 years ago

Okay I'll close this for now then. Feel free to open again with more error reports :)

Akhmath commented 3 years ago

@jashwanthl Keynote manager creates a lock file (in the same path as the keynote text file with the same name and .lock extension) to tell other Revit instances that it is writing data to the keynote file. This way multiple users won't overwrite each others changes. When the *.lock file exists, the keynote manager will wait for 10 seconds to see if the lock goes away or not. It will return the "Wait for unlock timeout" error if it does not.

With this background, I have a few questions:

  • Is the keynote file shared over the network? (shared network drive) In that case is there anything different between the working and none-working machines in the way the drives are mapped?
  • Is there a sticky .lock file stuck in the folder? One possibility might be if keynote manager crashed, it might leave a hanging .lock file

Hi, it looks like we have the issue where the network drives are mapped differently. would the solution be to simply have everyone's pcs map the drives in the same way? (there's no lock file in the folder)(its on autodesk's network drive, called BIM 360 on some PCs and called Autodesk Docs on other PCs)

eirannejad commented 3 years ago

Keynote manager uses the Autodesk Desktop Connector (ADC) API to synchronize and lock the keynote file on bim360. The drive named Autodesk Docs is the latest version of ADC so definitely test and see if this goes away if everyone is on the latest ADC version

JLee415 commented 3 years ago

Hello - We understand that when somebody is editing the notes it "locks" the .txt file on BIM360 and when they are done editing it unlocks the .txt file. But our current issue is when you add a note it is saying "user is editing..." which we cannot seem to clear it out..

image

cloghmani3182 commented 2 years ago

I am currently encountering the same issue as JLee415. Did anyone figure out a solution?

PAYAM2000 commented 1 year ago

This seems to still be an issue. any solution to this? We have been unlocking the text file on BIM360 and deleting the .lock file, but the issue doesn't get resolved. our workaround has been deleting the file and uploading a copy of the keynote file back on BIM360 again, it's a pain and I am hoping for a better solution!