search

pyrevitlabs / pyRevit

Rapid Application Development (RAD) Environment for Autodesk Revit®
http://wiki.pyrevitlabs.io
GNU General Public License v3.0
1.24k stars 326 forks source link

Convert Line Style crashes when closing with "x" button #971

Open vinnividivicci opened 3 years ago

vinnividivicci commented 3 years ago

Edit -> "Convert Line Styles" crashes Revit with fatal error when closing with "x" button

Steps to reproduce the behavior:

  1. Go to Edit -> "Convert Line Styles"
  2. Select a "From Style"
  3. Don't select anything in the right column "To Style"
  4. Close the dialog box
  5. Revit fatal error

Expected behavior I expect it to simply close the dialog box and not crash Revit 😄

Desktop (please complete the following information):

eirannejad commented 3 years ago

Hey I can't replicate this issue on Revit 2018-2021. There is something on your machine that is causing the bug.

vinnividivicci commented 3 years ago

Thanks for the response!

It crashes on the RAC_basic_sample_project as well.

It does not crash in other dialog boxes when closing them with the "x", only this one.

The key is that a line style must be selected in the left column and nowhere else and then close using the "x": image

I am running Windows 10 build 20190 (insider preview) in case it could be related...

GastonBC commented 2 years ago

It happens to me too. Also crashes when selecting items from both lists and then closing Happens in every project consistently and no other window causes a crash

Whippertoast commented 6 months ago

This is still an issue, why was an easily reproduceable fatal error marked as closed without being resolved? Currently you can't cancel this operation without the project crashing.

EDIT: I'll actually be helpful and add my details:

Steps to reproduce the behavior: As stated above. I've tested the following conditions:

  1. Selecting something in the "From Style" column only
  2. Selecting something in the "To Style" column only
  3. Selecting something in both columns
  4. Selecting something in both columns and hitting "Convert Selected Styles" (i.e moving styles to the box in the middle)

In all scenarios, when you follow it by closing the window and not going through with the conversion, it causes Revit to crash.

Interestingly, if I check "Convert Filled Region Lines" and/or "Delete Converted Styles" in addition to any of the four scenarios above, Revit does not crash when you close the window.

Desktop (please complete the following information):

OS: Windows 11 Pro for Workstations 22H2 Build: 22621.2715 Windows Feature Experience Pack: 1000.22677.1000.0 pyRevit Version 4.8.13 pyRevit Environment:

==> Registered Clones (full git repos)
==> Registered Clones (deployed from archive/image)
master | Deploy: "basepublic" | Branch: "master" | Version: "4.8.13.23182+2215" | Path: "C:\Users\User\AppData\Roaming\pyRevit-Master"
==> Attachments
master | Product: "Autodesk Revit 2024" | Engine: IPY277 (277) | Path: "C:\Users\User\AppData\Roaming\pyRevit-Master"
master | Product: "2024.0.1" | Engine: IPY277 (277) | Path: "C:\Users\User\AppData\Roaming\pyRevit-Master"
master | Product: "Autodesk Revit 2023" | Engine: IPY277 (277) | Path: "C:\Users\User\AppData\Roaming\pyRevit-Master"
master | Product: "2022 First Customer Ship" | Engine: IPY277 (277) | Path: "C:\Users\User\AppData\Roaming\pyRevit-Master"
==> Installed Extensions
==> Default Extension Search Path
C:\Users\User\AppData\Roaming\pyRevit\Extensions
==> Extension Search Paths
==> Extension Sources - Default
https://github.com/eirannejad/pyRevit/raw/master/extensions/extensions.json
==> Extension Sources - Additional
==> Installed Revits
Autodesk Revit 2024 | Version: 24.1.11.26 | Build: 20230911_1230(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2024\"
2024.0.1 | Version: 24.0.5.432 | Build: 20230411_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit LT 2024\"
Autodesk Revit 2023 | Version: 23.0.11.19 | Build: 20220503_1030(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit LT 2023\"
2022 First Customer Ship | Version: 22.0.2.392 | Build: 20210224_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit LT 2022\"
==> Running Revit Instances
Error: Object reference not set to an instance of an object.
Run with "--debug" option to see debug messages
github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 60 days with no activity.

sanzoghenzo commented 4 months ago

(reviving this to keep it open 😉 )

Is this still an issue with 4.8.14 and the IronPython 2.7.11 engine?

@jmcouffin One thing I'm noticing in the pyrevit env of some of the reports is that it breaks at Running Revit Instances with the message Error: Object reference not set to an instance of an object., could this be related? (I know you're not a C# guy, but you're my historical record 😅 maybe you've seen this before...)

jmcouffin commented 4 months ago

@jmcouffin One thing I'm noticing in the pyrevit env of some of the reports is that it breaks at Running Revit Instances with the message Error: Object reference not set to an instance of an object., could this be related? (I know you're not a C# guy, but you're my historical record 😅 maybe you've seen this before...)

mostly due to pyrevit-hosts file not being up to date / in line with revit version installed. I do not know the necessity of this file, I would love to get ride of it. But that needs to be discussed with the grand master.

Is this still an issue with 4.8.14 and the IronPython 2.7.11 engine?

yes and I can reproduce it. I even tried to solve it but could not find the culprit. The only way I found to solve it was to remove the X close button itself... Far from ideal @sanzoghenzo