search

pyro-kinetics / pyrokinetics

Python library to run and analyse gyrokinetics simulations
https://pyrokinetics.readthedocs.io/en/latest/#
GNU Lesser General Public License v3.0
25 stars 6 forks source link

Fix beta setting when directly specifying code #299

Closed bpatel2107 closed 8 months ago

bpatel2107 commented 9 months ago

Fixes #298 where beta was being overwritten when doing pyro.gk_code = "CGYRO" and added a test to check this setter matches all values in LocalGeometry, LocalSpecies and Numerics

bpatel2107 commented 9 months ago

@whornsby82 FYI

bpatel2107 commented 9 months ago

@ZedThree do you know what's going on with the formatting here? Only changed 2 files...

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.53%. Comparing base (febbaf3) to head (02a64cb).

:exclamation: Current head 02a64cb differs from pull request most recent head fc4c44e. Consider uploading reports for the commit fc4c44e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## unstable #299 +/- ## ========================================= Coverage 84.52% 84.53% ========================================= Files 46 46 Lines 6883 6886 +3 ========================================= + Hits 5818 5821 +3 Misses 1065 1065 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.