Closed LiamPattinson closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.18%. Comparing base (
261a2a7
) to head (ef9424c
). Report is 2 commits behind head on unstable.:exclamation: Current head ef9424c differs from pull request most recent head 462bf10
Please upload reports for the commit 462bf10 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've been experimenting with ways to keep units consistent across many simulations (Issue https://github.com/pyro-kinetics/pyrokinetics/issues/337) while also removing the need to repeatedly rebuild the pint units cache, which is significantly slowing down our tests (Issue https://github.com/pyro-kinetics/pyrokinetics/issues/326). I should have something to show for it shortly, but it's definitely something that should wait until after our next release.
In the process of this work, I found a bug in the
LocalGeometry
normalisation function:All quantities that depend on
lref
are set tonan
after normalising to a convention that doesn't uselref_minor_radius
. This PR fixes that so that the aspect ratio is taken into account during the conversion. I've implemented similar fixes forLocalGeometry
andLocalSpecies
.