search

pyro-kinetics / pyrokinetics

Python library to run and analyse gyrokinetics simulations
https://pyrokinetics.readthedocs.io/en/latest/#
GNU Lesser General Public License v3.0
25 stars 6 forks source link

Bugfix: Pin `idspy-dictionaries` version #358

Closed LiamPattinson closed 5 months ago

LiamPattinson commented 5 months ago

In PR https://github.com/pyro-kinetics/pyrokinetics/pull/357, all tests passed following the final push (https://github.com/pyro-kinetics/pyrokinetics/actions/runs/9372068998/job/25802746935). They then failed during the merge (https://github.com/pyro-kinetics/pyrokinetics/actions/runs/9415332642/job/25936125182), as idspy-dictionaries released a new version which is incompatible with our existing test data.

I'm not sure how to fix this one, but given our version of idspy-toolkit is pinned, the easiest solution was to pin idspy-dictionaries to the previous version. Perhaps we could raise an issue and come up with a longer term solution later?

bpatel2107 commented 5 months ago

I've spoken to @ycamenen and for now it is best to pin idspy-dictionaries until a new version of idspy-toolkit is released