search

pyro-ppl / brmp

Bayesian Regression Models in Pyro
Apache License 2.0
69 stars 8 forks source link

Move methods on to `Fit` class. #51

Closed null-a closed 4 years ago

null-a commented 4 years ago

This moves marginals, fitted etc. from top-level methods to methods on the Fit class. (Closes #50.)

I'm personally happy with either approach, but I'm guessing the change is worth making since the result is arguably more idiomatic. Agreed?

null-a commented 4 years ago

Great, thanks @neerajprad.