pyro-ppl / brmp

Bayesian Regression Models in Pyro
Apache License 2.0
69 stars 8 forks source link

Update Pyro to version 1.0 #73

Closed neerajprad closed 4 years ago

neerajprad commented 4 years ago

Additionally, attempts to fix #70.

The issue is that we cannot enforce order in a requirements.txt file and since PyTorch released a version 1.3.1 very recently, we were fetching a bigger file from pypi instead of the 1.3.0 cpu only hosted wheels (this was being fetched as a dependency of pyro-ppl). We could have fixed that by updating the torch dependency in requirements.txt to 1.3.1, but this would be a recurring issue with each update to pytorch.

Instead, the current workaround splits the installs into 2 requirement files - pytorch install + remaining, which should be more stable.

build

null-a commented 4 years ago

Great, sounds good to me.