pyro-ppl / funsor

Functional tensors for probabilistic programming
https://funsor.pyro.ai
Apache License 2.0
236 stars 20 forks source link

Add generalized parallel-scan algorithms for dynamic factor graphs #293

Open eb8680 opened 4 years ago

eb8680 commented 4 years ago

Generalizing tensor variable elimination to dynamic factor graphs

Optional or out of scope:

Parallel-scan operation implementation

Optional tasks:

eb8680 commented 3 years ago

@ordabayevy I copied the work plan from #398 to this issue. I suggest going ahead with making modified_partial_sum_product use the first-class Funsor funsor.sum_product.MarkovProduct in place of sequential_sum_product and testing that the result is fully compatible with funsor.optimizer.apply_optimizer, since I think that may be necessary for your problem, but the other stuff is less important.

ordabayevy commented 3 years ago

@eb8680 sounds good. Can you point to an example that tests compatibility with funsor.optimizer.apply_optimizer?

eb8680 commented 3 years ago

Can you point to an example that tests compatibility with funsor.optimizer.apply_optimizer?

See my PR #400 - that should address this point.