pyro-ppl / funsor

Functional tensors for probabilistic programming
https://funsor.pyro.ai
Apache License 2.0
236 stars 20 forks source link

dynamic_partial_sum_product that uses sarkka_bilmes_product #535

Closed ordabayevy closed 3 years ago

ordabayevy commented 3 years ago

Addresses https://github.com/pyro-ppl/funsor/issues/293

group coded with @fehiepsi @fritzo

Currently failing under lazy interpretation because of some sarkka_bilmes_product bug.

ordabayevy commented 3 years ago

Sorry, my master branch was messed up so there are some changes that appear in minipyro example. I'll fix this soon (#536 too).

eb8680 commented 3 years ago

Eagerly evaluated version looks good to me

ordabayevy commented 3 years ago

Thanks for reviewing @eb8680 !