search

pyro-ppl / numpyro

Probabilistic programming with NumPy powered by JAX for autograd and JIT compilation to GPU/TPU/CPU.
https://num.pyro.ai
Apache License 2.0
2.1k stars 227 forks source link

Censoring example notebook #1773

Closed juanitorduz closed 3 months ago

juanitorduz commented 3 months ago

Closes https://github.com/pyro-ppl/numpyro/issues/1771

Adds censoring example notebook.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

juanitorduz commented 3 months ago

I think I am ready for a first round of reviews :)

Remak: The pin scipy==1.12.0 is temporary as we wait for an arviz patch needed because of the scipy 1.13.0 release 2 days ago.

review-notebook-app[bot] commented 3 months ago

View / edit / reply to this conversation on ReviewNB

fehiepsi commented on 2024-04-03T20:02:44Z ----------------------------------------------------------------

could you remove the warning?


juanitorduz commented on 2024-04-03T20:11:55Z ----------------------------------------------------------------

sure!

review-notebook-app[bot] commented 3 months ago

View / edit / reply to this conversation on ReviewNB

fehiepsi commented on 2024-04-03T20:02:45Z ----------------------------------------------------------------

Line #45.    ax.set_title("Censored Gamma Sample Data", fontsize=16, fontweight="bold")

you can add ; at the end to remove the text output


_juanitorduz commented on 2024-04-03T20:12:18Z_ ----------------------------------------------------------------

Done!

review-notebook-app[bot] commented 3 months ago

View / edit / reply to this conversation on ReviewNB

fehiepsi commented on 2024-04-03T20:02:46Z ----------------------------------------------------------------

Line #7.    plt.gcf().suptitle("Poisson Model Parameter", fontsize=18, fontweight="bold")

nit: add ; at the end


_juanitorduz commented on 2024-04-03T20:14:44Z_ ----------------------------------------------------------------

Done!

juanitorduz commented 3 months ago

sure!

View entire conversation on ReviewNB

juanitorduz commented 3 months ago

Done!

View entire conversation on ReviewNB

juanitorduz commented 3 months ago

Done!

View entire conversation on ReviewNB

juanitorduz commented 3 months ago

I addressed all comments from the first review cycle :)

fehiepsi commented 3 months ago

Awesome work, @juanitorduz! The content is very clear and interesting. Thanks for sharing!

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.