pyro-ppl / numpyro

Probabilistic programming with NumPy powered by JAX for autograd and JIT compilation to GPU/TPU/CPU.
https://num.pyro.ai
Apache License 2.0
2.15k stars 234 forks source link

Support multidimensional HSGP (numpyro.contrib.hsgp) #1803

Closed brendancooley closed 4 months ago

brendancooley commented 4 months ago

The results in @juanitorduz notebook replicate with one change to function arguments.

TODO (on this PR or future)

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

brendancooley commented 4 months ago

^ fix pushed for python 3.9 typing issues causing CI failure

brendancooley commented 4 months ago

^once more, fix for linting

juanitorduz commented 4 months ago

This looks super cool @brendancooley ! I this one ready for review?

juanitorduz commented 4 months ago

Regarding the TODOS:

juanitorduz commented 4 months ago

@fehiepsi any hints on the examples CI failing because other tests not relevant to this PR 😄 ?

brendancooley commented 4 months ago

@brendancooley This is amazing! I could have never done this in a cleaner way 🙌 ! Thank you!

I left two suggestions regarding documentation and some additional simple unit-tests to make this bullet-proof and to help other devs get what are the auxiliary functions expected to output. Besides that is a ✅ from my side.

Thanks the feedback @juanitorduz! Will push a commit including responses to your suggestions shortly.

brendancooley commented 4 months ago

@fehiepsi any hints on the examples CI failing because other tests not relevant to this PR 😄 ?

It looks like the stein_bnn example is sporadically failing to pull the boston housing data. I've been able to replicate locally but not consistently.

brendancooley commented 4 months ago

Regarding the TODOS:

  • The first one we can leave for other PRs so that we work on iterations (would you mind creating an issue?).
  • The second would be good to change after we merge this one.
  • I do not know if the third one is necessary as maybe this could serve as a "raw" example. No strong opinion. Still, we can open an issue but definitively not part of this PR.

issue for vector-valued lengthscale up! https://github.com/pyro-ppl/numpyro/issues/1805

brendancooley commented 4 months ago

This looks great! very nice to review :D

Thanks again!