Closed brendancooley closed 4 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
^ fix pushed for python 3.9 typing issues causing CI failure
^once more, fix for linting
This looks super cool @brendancooley ! I this one ready for review?
Regarding the TODOS:
@fehiepsi any hints on the examples CI failing because other tests not relevant to this PR 😄 ?
@brendancooley This is amazing! I could have never done this in a cleaner way 🙌 ! Thank you!
I left two suggestions regarding documentation and some additional simple unit-tests to make this bullet-proof and to help other devs get what are the auxiliary functions expected to output. Besides that is a ✅ from my side.
Thanks the feedback @juanitorduz! Will push a commit including responses to your suggestions shortly.
@fehiepsi any hints on the examples CI failing because other tests not relevant to this PR 😄 ?
It looks like the stein_bnn
example is sporadically failing to pull the boston housing data. I've been able to replicate locally but not consistently.
Regarding the TODOS:
- The first one we can leave for other PRs so that we work on iterations (would you mind creating an issue?).
- The second would be good to change after we merge this one.
- I do not know if the third one is necessary as maybe this could serve as a "raw" example. No strong opinion. Still, we can open an issue but definitively not part of this PR.
issue for vector-valued lengthscale
up! https://github.com/pyro-ppl/numpyro/issues/1805
This looks great! very nice to review :D
Thanks again!
eigenindices
function, following Eq 10 in Riutort-Mayol et aleigenfunctions
to handle multidimensionalx
. Vector-valued inputs are treated as unidimensional problems. Otherwise the trailing dimension ofx
is inferred as the dimension of the input space. All preceding dims are treated as batch dims.laplacian
andapproximation
functions to accept list-valued inputs form
andell
. If an int (m
) or float (ell
) is passed when the problem is multidimensional, the same value is used for all dimensions.The results in @juanitorduz notebook replicate with one change to function arguments.
TODO (on this PR or future)
numpyro.contrib.hsgp
numpyro.contrib.hsgp