pyro2927 / AWS_SSO_Containers

Firefox extension to route AWS SSO logins into unique containers.
https://addons.mozilla.org/en-US/firefox/addon/aws-sso-containers/
63 stars 16 forks source link

Use openerTabId to maintain tree position #1

Closed cjallen88 closed 1 year ago

cjallen88 commented 1 year ago

I noticed while using this extension that when the new containerized tab is created and the old one removed, that the position in the tab tree (I'm using sideberry extension, but probably affects other tree style tab exts) gets confused.

See images below - when the new tab is opened by clicking 'management console' under an account, the parent somehow absorbs the next sibling tab as a child.

Before opening tab:

Screenshot 2023-02-14 at 17 07 19

After opening tab:

Screenshot 2023-02-14 at 17 07 40

This change appears to fix the issue

cjallen88 commented 1 year ago

This didn't reliably fix it after all, I've made another local change to take better care around functions that return promises, so we'll see how that goes.