search

pyro2927 / AWS_SSO_Containers

Firefox extension to route AWS SSO logins into unique containers.
https://addons.mozilla.org/en-US/firefox/addon/aws-sso-containers/
55 stars 16 forks source link

Workaround for an issue with long container names #26

Open acahill opened 1 month ago

acahill commented 1 month ago

Hi @pyro2927, thank you so much for this extension, I've been using it for a while now and it makes dealing with frequently switching roles way easier. This isn't a problem with the AWS SSO Containers addon really, but the Firefox Multi-Account Containers addon has a long-standing issue where long container names wrap in a way that makes them jumbled and sometimes illegible:

container-name-wrapping-fixed

As far as I can tell, the Mozilla team has ignored the issue [Long Names Word wrap are overlapping with other entries

2544](https://github.com/mozilla/multi-account-containers/issues/2544), which is probably fair enough given the usual 25-character limit. That doesn't apply to this addon, so a while back I patched in a few minor changes to add an option to limit the max length and truncate the name with an ellipsis:

container-name-dialog-fixed

That turned out to work really well, except if you make the length so short the names end up being identical. Anyway, I put the changes on a fork of the repository https://github.com/acahill/AWS_SSO_Containers, which is now trailing a little bit but still works just fine for me. Is that useful to anyone else? I could rebase it and make a pull request if it helps.

pyro2927 commented 1 month ago

@acahill if you rebase I'll take the change

acahill commented 1 month ago

Brilliant, thanks! I've added a pull request #28