search

pyrocko / kite

InSAR unwrapped surface displacement processing for earthquake modelling.
https://pyrocko.org/kite/
GNU General Public License v3.0
78 stars 34 forks source link

Fix installation issues and compatibility with current pyrocko and pyqtgraph #115

Closed emolch closed 6 months ago

emolch commented 7 months ago

Should fix #113.

Tested in a pip env with --system-site-packages on Ubuntu 22.04 and system installed pyqtgraph, qt5, etc.

Isolated pip env install is still broken because of incompatibility with newer pyqtpgraph. Simple downgrading of pyqtgraph did not help because of incompatibilities between pyqtpgraph/qt5/numpy.

emolch commented 7 months ago

Now includes some patches to get it working in newer pyqtgraph.

miili commented 7 months ago

Thanks for the PR. I believe moving to something like https://github.com/pdm-project/pdm can help with cleaner dependencies. I will have a look next week.

hvasbath commented 7 months ago

I confirm that with this branch the error does not occur anymore! Tested on python3.8 and 3.11. ubuntu 20.04

hvasbath commented 7 months ago

When testing stumbled upon another issue when loading the scene. with spool. Pyqtgraph version 0.11 and 0.12 have an issue which is fixed in 0.13. See here: https://github.com/pyrocko/kite/issues/114 So maybe we should fix the version in the requriements to >=0.13? So in order to support younger pyqtgraphs we would need to write a wrapper around the show_grid method to fix their int/float conversion issues calling the function ...

hvasbath commented 7 months ago

Another issue: https://github.com/pyrocko/kite/issues/117

hvasbath commented 7 months ago

Ok I didnt stumble on another issue using: Ubuntu 20.04, python3.8, pyqtgraph 0.13.3

emolch commented 7 months ago

When testing stumbled upon another issue when loading the scene. with spool. Pyqtgraph version 0.11 and 0.12 have an issue which is fixed in 0.13. See here: #114 So maybe we should fix the version in the requriements to >=0.13? So in order to support younger pyqtgraphs we would need to write a wrapper around the show_grid method to fix their int/float conversion issues calling the function ...

Ubuntu 22.04 ships with pyqtgraph 0.12, so please don't set the requirements to >=0.13, it would break system native installs. Because also the qt5 version is older there, there is no problem with that combination. If there is any, we can certainly add a small fix.

miili commented 6 months ago

lgtm