Rename theta and phi to azimuth and incident/takeoff/emergence

pyrocko / kite

InSAR unwrapped surface displacement processing for earthquake modelling.

https://pyrocko.org/kite/

GNU General Public License v3.0

79 stars 34 forks source link

Rename theta and phi to azimuth and incident/takeoff/emergence #97

Open miili opened 1 year ago

miili commented 1 year ago

Naming the LOS angles theta and phi was a really awful idea.

We should use clear naming for the angles: azimuth and emergence

hvasbath commented 1 year ago

I agree, however, I would rather opt for heading instead of azimuth, emergence would be ok for me.

miili commented 1 year ago

Heading can be a little misleading since we are looking at the reference system (point of observation) of the satellite. Azimuth on the other hand implies a spherical coordinate system. Maybe @hsudha has an opinion on this?