search

pyroclient / pyro

10 stars 4 forks source link

[BUG] Player Models stuck looking at one side. #415

Open zincodrone opened 3 years ago

zincodrone commented 3 years ago

Describe the bug A clear and concise description of what the bug is. Currently, Player Models are locked only looking at one side this is basically everywhere even if you're moving your head. HudEditor mode unlocks this but only when EditHub mode is activated. To Reproduce Steps to reproduce the behavior:

  1. Turn on module: HudEditor
  2. Turn on Player Models.
  3. Exit to regular gameplau
  4. Player Models will be locked looking towards one position.
  5. Turn on HudEditor.
  6. Player Models will unlock

Expected behavior A clear and concise description of what you expected to happen. Movement of the head should be not locked towards just one position and if so should be locked looking straight at the screen not to one side.

Screenshots Add screenshots or videos to help explain the problem. image Additional context Add any other context about the problem here.

arlomcwalter commented 3 years ago

I'm fairly sure the method of rendering playermodel uses mousePos X and Y to determine the yaw, pitch and headYaw of the playermodel, this is why the model only appears to rotate when the mouse is moved. Correct me if im wrong but this is not a bug.

zincodrone commented 3 years ago

No this is a bug. Other clients w/ this same render do not have this issue. It's due to them using mousePos instead of rendering it w/ taking into account the current looking pos. MousePos should not be used in this circumstance because MousePos only works if the mouse is rendered all the time while outside the Esc menu.

arlomcwalter commented 3 years ago

i know that… the point i was making is that i am fairly sure the method (the part of the code used to define how to render an entity on screen) that pyro uses to render the playermodel uses the mouseX and mouseY parameters. It is not a bug, but you could potentially suggest that they use a custom method, rather than the one from the inventory screen class, to render the playermodel. Bugs and suggestions have also moved to the discord server, they can now be made using the !report command through pyro bot.