pyrolabs / overwire

A library for loading dependencies over the wire
MIT License
1 stars 0 forks source link

Arguments passed into `load` are being discarded. #3

Closed fluffywaffles closed 1 month ago

fluffywaffles commented 7 years ago
export default {
  load: () => {
    loadScripts()
      .then(() => {
        determineRequiredBundles()
        loadRequiredBundles()
      })
  }
}

If I call load([ './my-script.js' ]) it's not going to pass that argument into loadScripts and my script will not load. Unless you're using some kind of evil webpack magic to compile this so that arguments are always passed, I don't think your README is correct.

prescottprue commented 7 years ago

@fluffywaffles This library was actually just migrated over to being built this way from a demo application.

You are correct about the README and the API not being valid yet. Over the next few days it will change quite a bit.

sbolel commented 7 years ago

Nice catch @fluffywaffles, thank you!

This seems to be related to #4