search

pyrolabs / overwire

A library for loading dependencies over the wire
MIT License
1 stars 0 forks source link

Simplify API? #4

Closed fluffywaffles closed 1 month ago

fluffywaffles commented 7 years ago

Since you named the parameter scriptUrlsArr and your README example clearly expects the argument to be an array and your tests (well, test) uses an array as the only argument, you can probably remove the branch of the code that tests if the type of the argument is a string and handles that case. That case should cause an error, not succeed silently. It's not the correct usage of the API. Correct me if wrong.

sbolel commented 7 years ago

Correct. Great catch!

We'll get a PR started, help is always appreciated :)