search

pyroll-project / pyroll-core

PyRoll rolling simulation framework - core library.
https://pyroll.readthedocs.io
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

Update orientation Hook #112

Closed ChRen95 closed 10 months ago

ChRen95 commented 10 months ago

Update the orientation hook in RollPass to also accept strings, therefore one could just pass vertical, horizontal, Y or AntiY. This would be more convenient for the human eye.

axtimhaus commented 10 months ago

Good idea, but there is only the type of the hook updated. No implementation for this logic?

ChRen95 commented 10 months ago

Just saw that core handles rotating therefore will need to implement the logic.

ChRen95 commented 10 months ago

Ready for merging

axtimhaus commented 10 months ago

Should we consider to make Y configuration the default for 3-roll-passes?

ChRen95 commented 10 months ago

Yes, let's make Y our default.