search

pyroll-project / pyroll-core

PyRoll rolling simulation framework - core library.
https://pyroll.readthedocs.io
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

198 add angle for profile and diskelementprofile #199

Closed ChRen95 closed 3 months ago

ChRen95 commented 5 months ago

Closes #198.

@axtimhaus, I also implemented roll_angle for "normal" in_profile and out_profile. This is redundent with roll_pass.entry_angleand roll_pass.exit_angleshall we keep it or remove it? I thought off keeping or better implementing them to keep consistency between disked and non disked profiles.

ChRen95 commented 3 months ago

Ready to merge

ChRen95 commented 3 months ago

Committed your changes.

ChRen95 commented 3 months ago

Fixed all angles