pyroll-project / pyroll-core

PyRoll rolling simulation framework - core library.
https://pyroll.readthedocs.io
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

`init_solve` method with predefined `in_profile` #201

Closed ChRen95 closed 2 months ago

ChRen95 commented 3 months ago

Summary

The init_solve method witch is used to in DiskElementUnit and other units, should feature a kwarg or other variable to give a predefined in_profile.

Detailed Description

For solving of differential equations, like Karman's differential equation for rolling, one has to set the initial conditions. This is done by providing a in_profile, which defines the initial state used for solving. Otherwise plugins will feature a great amount of if and else conditions to check which state a profile has.

My Suggestion would be, to provide a further variable to this method and checking if it is set. This means, that all the necessary values have to be set initially like also the height etc which would make manual initialization a bit hacky. Otherwise a combination of the classic solve procedure and predefined values would be nice but currently I can't think of a proper way of implementation.

Further Information, Files, and Links