search

pyroll-project / pyroll-core

PyRoll rolling simulation framework - core library.
https://pyroll.readthedocs.io
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

Request for strain rate in transport #67

Closed JMantel closed 1 year ago

JMantel commented 1 year ago

Would need strain rate of roll pass for calculation of static (and metadynamic) recrystallization in jmak-module. At the moment it is not included in the transport and therefore I can't access it. JMAK should function apart from the issue with the strain rate.

ChRen95 commented 1 year ago

I would suggest we add the strain rate to the 'Profile' as well. But I would be carefull with nameing in this case. The other option would mean that every unit would need to know the previous unit through weak references but that would be of greater afford. @axtimhaus do you have a suggestion as well?

axtimhaus commented 1 year ago

The cleanest way would be to access the strain_rate of the previous roll pass in the sequence using the Unit.prev attribute. @ChRen95 your suggestion is already done there ;)

An example can be found in Rotator.prev_roll_pass and the Rotator.rotation hook implementations. It could be, however, sensible to add a similar property to Transport for ease of plugin programming. Maybe construct a mixin for this.