pyroll-project / pyroll-docs

PyRoll rolling simulation framework - documentation website.
https://pyroll.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

"sequence.out_profile.temperature > sequence2.out_profile.temperature" command gives an error #11

Closed philipcardiff closed 10 months ago

philipcardiff commented 10 months ago

At the bottom of the page https://pyroll.readthedocs.io/en/latest/examples/pyroll-examples/Basic_Usage_Of_PyRolL.html, the command sequence.out_profile.temperature > sequence2.out_profile.temperature gives the following error for me:

╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ in <module>:1                                                                                    │
│                                                                                                  │
│ ❱ 1 sequence.out_profile.temperature > sequence2.out_profile.temperature                         │
│   2                                                                                              │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
AttributeError: 'NoneType' object has no attribute 'temperature'

Everything in this tutorial up to this point works as expected, but something is not correct when accessing in_profile and out_profile from a sequence object.

By the way, this is a very nice, intuitive tutorial! Thanks.

Note: This is related to the review at https://github.com/openjournals/joss-reviews/issues/6200

philipcardiff commented 10 months ago

Apologies, I found the (my) mistake; I missed the command which runs the sequence2 simulation:

sequence2.solve(in_profile)

Now, the sequence.out_profile.temperature > sequence2.out_profile.temperature command works as described.

This issue can be closed.