pyroll-project / pyroll-linear-thermal-expansion

Plugin for PyRoll providing approximate thermal expansion behavior using thermal expansion factor.
https://pyroll.readthedocs.io
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Temperature inclusion #1

Closed ChRen95 closed 3 months ago

ChRen95 commented 1 year ago

When using the pyroll-ring-model-thermal and therefore, defining a in_profile using core_temperature and surface_temperature the plugin won't work since it hardcoded uses profile.temperature.

Suggested change would be to implement a check in the plugin to calculate the mean temperature inside the plugin. If @axtimhaus has no other suggestions I would implement it like that.

axtimhaus commented 1 year ago

Why would you define a Profile with solely core and surface temperature? Where are the rings between? If you define all rings, it shall work, since temperature is calculated as a weighted mean of them

ChRen95 commented 1 year ago

Availability of measurements is the magic therm. On can sometimes assume a temperature gradient over a profile but providing the ring temperatures from both values should be handled by the plugin

axtimhaus commented 1 year ago

But this is than a matter of the ring model, not of linear expansion. There you have to define an assumption whats happening inside, when only core and surface are given

axtimhaus commented 1 year ago

Linear expansion does not know anything about rings. It is just working with mean temperature by design. If desired on a per-ring basis, make a new plugin pyroll-ring-model-thermal-expansion or similar.