Closed frgfm closed 2 years ago
Merging #208 (9fba130) into master (5f719ff) will increase coverage by
0.94%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 92.58% 93.52% +0.94%
==========================================
Files 34 46 +12
Lines 1213 1281 +68
==========================================
+ Hits 1123 1198 +75
+ Misses 90 83 -7
Flag | Coverage Δ | |
---|---|---|
unittests | 93.52% <100.00%> (+0.94%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/app/api/crud/accesses.py | 97.56% <100.00%> (ø) |
|
src/app/api/crud/authorizations.py | 100.00% <100.00%> (ø) |
|
src/app/api/crud/base.py | 100.00% <100.00%> (+1.85%) |
:arrow_up: |
src/app/api/deps.py | 92.10% <100.00%> (+0.21%) |
:arrow_up: |
src/app/api/routes/accesses.py | 100.00% <100.00%> (ø) |
|
src/app/api/routes/alerts.py | 98.18% <100.00%> (-0.35%) |
:arrow_down: |
src/app/api/routes/devices.py | 100.00% <100.00%> (ø) |
|
src/app/api/routes/events.py | 100.00% <100.00%> (ø) |
|
src/app/api/routes/groups.py | 100.00% <100.00%> (ø) |
|
src/app/api/routes/installations.py | 100.00% <100.00%> (ø) |
|
... and 21 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5f719ff...9fba130. Read the comment docs.
As discussed in #176, this PR introduces the following modifications:
update_alert
,link_media
,update_media
device_id
andmedia_id
mandatory and non-nullable for alertsspecified_only
mechanism from #113Closes #176
Any feedback is welcome!