pyronear / pyro-api

Alert Management API for wildfire prevention, detection & monitoring. Built with FastAPI & PostgreSQL
Apache License 2.0
21 stars 9 forks source link

feat: Improve dev experience by using local S3 #244

Closed Acruve15 closed 1 year ago

Acruve15 commented 1 year ago

Description

Linked to Issue 217. Developing locally is not possible if the developer does not have an AWS S3 access.

What was done

We used localstack to solve this issue.

codecov[bot] commented 1 year ago

Codecov Report

Merging #244 (e6079a3) into main (5be37ab) will decrease coverage by 0.17%. The diff coverage is n/a.

:exclamation: Current head e6079a3 differs from pull request most recent head 98a68ab. Consider uploading reports for the commit 98a68ab to get more accurate results

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   94.95%   94.78%   -0.17%     
==========================================
  Files          63       57       -6     
  Lines        1505     1322     -183     
==========================================
- Hits         1429     1253     -176     
+ Misses         76       69       -7     
Flag Coverage Δ
unittests 94.78% <ø> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 40 files with indirect coverage changes

Acruve15 commented 1 year ago

Thanks a lot for the PR @Acruve15 🙏

I added a few comments but this is looking really good! I have one extra request: is this running in the CI tests?

Hey @frgfm, localstack was added on part of the tests, tell me if it's good for you, thx

frgfm commented 1 year ago

Any update @Acruve15 ? :smiley: It would be a shame that we don't use your work!

blenzi commented 1 year ago

Hi @Acruve15, very nice addition! I tried to run this locally but make test fails on the docker-compose exec localstack command. If I issue the command by hand again it works. Any idea ?

Acruve15 commented 1 year ago

@frgfm thx for merging!