pyronear / pyro-api

Alert Management API for wildfire prevention, detection & monitoring. Built with FastAPI & PostgreSQL
Apache License 2.0
21 stars 9 forks source link

fix: authentication, alert payload and exception handling in api_e2e.py #245

Closed blenzi closed 1 year ago

blenzi commented 1 year ago

This PR fixes the script for end-to-end tests.

codecov[bot] commented 1 year ago

Codecov Report

Merging #245 (24d1b99) into main (2b00bb3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          60       60           
  Lines        1395     1395           
=======================================
  Hits         1325     1325           
  Misses         70       70           
Flag Coverage Δ
client 100.00% <ø> (ø)
unittests 94.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

frgfm commented 1 year ago

Hey there :)

Thanks a lot for the fix! Could you merge main into this branch please? :pray: (#255 re-enabled the script job) Perfect occasion to make this script work properly!

frgfm commented 1 year ago

I took the liberty to apply the multiple fixes, everything's alright now :+1: