pyronear / pyro-api

Alert Management API for wildfire prevention, detection & monitoring. Built with FastAPI & PostgreSQL
Apache License 2.0
21 stars 9 forks source link

Grouping alerts #280

Closed MateoLostanlen closed 1 year ago

MateoLostanlen commented 1 year ago

Hi there,

I'm trying to understand why the grouping of alerts doesn't work. Maybe I'm misunderstanding but it seems to me that we should put a symbol <= here to have the alerts created within the last 30 minutes, right?

@frgfm @blenzi what do you think ?

blenzi commented 1 year ago

Hi @MateoLostanlen , I think >= is correct since max_ts = now - 30 minutes and this is querying previous alerts. A query with <= would return all previous alerts (not within the last 30 minutes).

blenzi commented 1 year ago

In the end the mechanism is working but the deployed version had the old value of 5 minutes. Closing