pyronear / pyro-api

Alert Management API for wildfire prevention, detection & monitoring. Built with FastAPI & PostgreSQL
Apache License 2.0
21 stars 9 forks source link

fix(client): handle the final slash sensitivity on core routers #317

Closed frgfm closed 5 months ago

frgfm commented 5 months ago

This PR introduces the following modifications:

Any feedback is welcome! cc @MateoLostanlen

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.39%. Comparing base (86f426c) to head (b5737ea).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #317 +/- ## ========================================== - Coverage 94.59% 94.39% -0.21% ========================================== Files 63 66 +3 Lines 1591 1676 +85 ========================================== + Hits 1505 1582 +77 - Misses 86 94 +8 ``` | [Flag](https://app.codecov.io/gh/pyronear/pyro-api/pull/317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/pyronear/pyro-api/pull/317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear) | `90.58% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/pyronear/pyro-api/pull/317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear) | `94.59% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MateoLostanlen commented 5 months ago

Thanks @frgfm for fixing this bug and for adding the test, let me know when you've fixed it :smiley:

frgfm commented 5 months ago

Alright, all tests passed, everything is backward compatible! I'll merge this to clean up other things in the mean time