Open RonanMorgan opened 4 months ago
Attention: Patch coverage is 91.66667%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 94.27%. Comparing base (
767be30
) to head (571e3c5
).
Files | Patch % | Lines |
---|---|---|
src/app/api/endpoints/media.py | 88.23% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
some thoughts / questions : => this PR is useless, I should I have implemented the pagination code in the client part, not in the API part, no ? => Can I add the boto dependency in the client ? => instead of using fetch_media I should have used get_media_url => Mateo needs Alerts + URL
I think the pagination idea is great for all the "fetch" routes, perhaps we should revisit this for all endpoints. Some rebasing is needed first though :sweat_smile:
Yes I will go back to this pagination after the end of the big refactor :) I think I will create a brand new PR
In order to facilitate data science management I have refactored the endpoint "fetch_media" : I have added a start_date, an end_date to gather images during this time period and a pagination parameter in order to get images 10 by ten
=> still need to adapt pyro-client and to add test in the client part