search

pyronear / pyro-api

Alert Management API for wildfire prevention, detection & monitoring. Built with FastAPI & PostgreSQL
Apache License 2.0
21 stars 9 forks source link

Psycopg dependency error #368

Open RonanMorgan opened 5 days ago

RonanMorgan commented 5 days ago

This is fixing the following error :

ModuleNotFoundError: No module named 'psycopg2'

It seems that the async driver asyncpg still has a dependency to the psycopg2 driver (for errors definition)

socket-security[bot] commented 5 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/psycopg2-binary@2.9.9 environment, eval, filesystem, network, shell, unsafe 0 10.6 MB piro

View full report↗︎

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.58%. Comparing base (92b9e28) to head (2b4d90c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## ======================================= Coverage 86.58% 86.58% ======================================= Files 31 31 Lines 857 857 ======================================= Hits 742 742 Misses 115 115 ``` | [Flag](https://app.codecov.io/gh/pyronear/pyro-api/pull/368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/pyronear/pyro-api/pull/368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear) | `86.18% <ø> (ø)` | | | [client](https://app.codecov.io/gh/pyronear/pyro-api/pull/368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear) | `91.80% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyronear#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frgfm commented 5 days ago

Thanks for the PR! Seems like the review will be straight forward: can you specify how to reproduce the error though? I haven't met that error neither the CI, so either we need to update the CI to reproduce that or we don't have the same environment :sweat_smile:

RonanMorgan commented 3 days ago

hum ok I think this happened because this part "+asyncpg" was not in the database URL in the production docker-compose I found so it should be ok now