Closed frgfm closed 2 years ago
Hello @frgfm!
Sorry for answering this issue so late, we have indeed added to our to-do list the removal of local data files from the repository. These are:
cameras.csv
- Everything is ready to tackle this one thanks to the get_sites
function of the API client (thanks a lot for the work done on that side by the way!). We are going to implement it soon with @abdi-adel 😊
departments.geojson
- For this one, we cannot directly use the file available online since the website was recently down for several weeks in a row according to @chloeskt. Apparently, in the pyro-risk repository, it was attached to a release. So, what do you think is best between fetching the file from there or having it released in the pyro-platform repository too? If the first option is fine, we can implement it very shortly.
historic_fires.csv
- There might be a bit more material for discussion here but I must admit I have no idea what would be the best practice.
No worries, we all had our hands busy!
departments.geojson
: for now, yes it would be a good idea to fetch it from the release when you start the app (if it's not already downloaded)historic_fires.csv
: this one will in the end be available through the API as well. The key here would perhaps be to add some previous wildfires thoroughly in the API DBThanks for your answer 🙏
I have made a quick test in a notebook to check whether we can fetch the .geojson
file from the release and it works just fine. We will implement it very soon in the app itself.
As for historic_fires.csv
, it would be great to eventually call it through the API indeed! Should we open a dedicated issue in the pyro-api
repository for instance? So that we can show you in more details the preprocessing logic we have established and what the raw data files look like.
Cool for the geojson!
Yes, I just checked there is no available method in the API client so far (but I doubt we'll need to implement a route in the API itself)
NB: I opened this issue in the Pyro-API repository to discuss the addition of historic fires to the database 🙂
We discussed where it could be stored, but I might have a better question @pyronear/front-end : what is the feature related to historic past wildfires? Do we really need it?
This is a monitoring platform so I don't see the value of displaying static information. If we are to display past events happening in their region, we need to fetch it through the API. But I'm starting to wonder whether these historic fires shouldn't be removed, what do you think?
Simply put, graphics assets could indeed be stored in the git history as they have a very limited size (event though we could avoid it). However, content files like the French geojson or wildfire history data should be moved to release attachments or on cloud storage to preserve git history sanity.
They could be downloaded when the app starts and cached.