pyronear / pyro-platform

Detection & monitoring platform of wildfires
https://platform.pyronear.org/
Apache License 2.0
10 stars 11 forks source link

[Content] Large content files should be removed from repo #35

Closed frgfm closed 2 years ago

frgfm commented 3 years ago

Simply put, graphics assets could indeed be stored in the git history as they have a very limited size (event though we could avoid it). However, content files like the French geojson or wildfire history data should be moved to release attachments or on cloud storage to preserve git history sanity.

They could be downloaded when the app starts and cached.

pechouc commented 3 years ago

Hello @frgfm!

Sorry for answering this issue so late, we have indeed added to our to-do list the removal of local data files from the repository. These are:

frgfm commented 3 years ago

No worries, we all had our hands busy!

pechouc commented 3 years ago

Thanks for your answer 🙏

I have made a quick test in a notebook to check whether we can fetch the .geojson file from the release and it works just fine. We will implement it very soon in the app itself.

As for historic_fires.csv, it would be great to eventually call it through the API indeed! Should we open a dedicated issue in the pyro-api repository for instance? So that we can show you in more details the preprocessing logic we have established and what the raw data files look like.

frgfm commented 3 years ago

Cool for the geojson!

Yes, I just checked there is no available method in the API client so far (but I doubt we'll need to implement a route in the API itself)

pechouc commented 3 years ago

NB: I opened this issue in the Pyro-API repository to discuss the addition of historic fires to the database 🙂

frgfm commented 2 years ago

We discussed where it could be stored, but I might have a better question @pyronear/front-end : what is the feature related to historic past wildfires? Do we really need it?

This is a monitoring platform so I don't see the value of displaying static information. If we are to display past events happening in their region, we need to fetch it through the API. But I'm starting to wonder whether these historic fires shouldn't be removed, what do you think?