pyronear / pyro-platform

Detection & monitoring platform of wildfires
https://platform.pyronear.org/
Apache License 2.0
10 stars 11 forks source link

Adding basic cameras information when hovered on map #9

Closed VincGargasson closed 4 years ago

VincGargasson commented 4 years ago

This PR change a bit the function to grab the info when hovering the mouse over the map. If the user hover over :

A second commit should include popup when clicking on marker.

Capture d’écran 2020-10-21 à 15 12 40 Capture d’écran 2020-10-21 à 15 12 27

frgfm commented 4 years ago

Mmmh, could you merge master into your branch @VincGargasson please? There seems to be some conflicts and for reasons I don't exactly get, the CI did not trigger :thinking:

nrslt commented 4 years ago

I see there are just 2 minor issues with codacy (related to docstrings), it should only take a few seconds ;)

VincGargasson commented 4 years ago

@frgfm @pechouc @nrslt Need your help. Codacy drives me crazy ! It state blank line required between summary line and description in app/utils.py while they asked me just before to start the description at the first line.

Any of you has an hint of what's going on? :) Thanks

pechouc commented 4 years ago

I had the same issue with a previous PR, Codacy is trying to verify two styling rules that are not compatible. The only thing to do is to ignore the remaining comments, since Codacy is not blocking the merge anyway!

frgfm commented 4 years ago

@VincGargasson yes exactly, it's not blocking because it goes a bit nuts on small things like this. Don't mind them!

VincGargasson commented 4 years ago

I had the same issue with a previous PR, Codacy is trying to verify two styling rules that are not compatible. The only thing to do is to ignore the remaining comments, since Codacy is not blocking the merge anyway!

Thanks for your replies. Can you please approve it as I corrected the mistakes you rose ;)