refactor: use API from env variable instead of hardcoded URL

pyronear / pyro-platform

Detection & monitoring platform of wildfires

https://platform.pyronear.org/

Apache License 2.0

10 stars 11 forks source link

refactor: use API from env variable instead of hardcoded URL #91

Closed blenzi closed 1 year ago

blenzi commented 1 year ago

Replace https://api.pyronear.org by $API_URL
style: fix headers, black and mypy corrections (add __init__.py files)
upgrade certifi

blenzi commented 1 year ago

The secrets are most likely outdated and that is probably why the tests are failing. See for instance: https://github.com/pyronear/pyro-platform/actions/runs/4682835248/jobs/8297190366?pr=91#step:4:40

blenzi commented 1 year ago

Thanks @frgfm !

Happy to go back to the previous version of black but not sure when it was changed and which version was used. So if you can do the PR, even better
For the copyright, this is what the headers check impose

frgfm commented 1 year ago

Happy to go back to the previous version of black but not sure when it was changed and which version was used. So if you can do the PR, even better

Yup I'll take care of this tomorrow :+1:

For the copyright, this is what the headers check impose

My bad, the message doesn't give a dynamic suggestion per file, I'll do this at the same time. Then we'll be able to merge main into this PR branch and we'll be good to go :ok_hand:

blenzi commented 1 year ago

Thanks @Akilditu . @frgfm, we need to move forward asap to have the platform running. So I will merge the PR and we can follow the discussion about the code quality checks on #92 .