fix: Fixes interactions with alert API & style tool version constraints

pyronear / pyro-platform

Detection & monitoring platform of wildfires

https://platform.pyronear.org/

Apache License 2.0

10 stars 11 forks source link

fix: Fixes interactions with alert API & style tool version constraints #92

Closed frgfm closed 1 year ago

frgfm commented 1 year ago

This PR is meant to be merged before #91 to solve a few aspects:

pinning the black version used by the CI
doing the same for the mypy version
updating the service name to a more appropriate one
fixed the headers

Apart from codebase edits, I did:

boot a dev bucket & API instance
updated the secrets in this repo accordingly

Final note: it's "normal" that some CI jobs fail as the API url is not dynamic yet until #91 is merged

blenzi commented 1 year ago

Thanks @frgfm ! Now the credentials are fixed, I re-ran the checks in #91 and they now pass

The issue with mypy was fixed #91 (commit 7439ff31563dfb0d8836fee06f60da1b7238b12e)
I didn't ask before but why do you think it is better to stick to the previous version of black instead of moving to the one used in #91 (and sticking to that version) ?

If we move to the new version of black (23.3.0), I will be able to merge the changes here without conflicts. The spaces it removes do not look really useful.

frgfm commented 1 year ago

My apologies for the late reply @blenzi :upside_down_face:

Regarding black, we need to stick to one version. And the one I specified in this PR is the one that has been used on all our repos so I suggest staying on that one for harmonization sake :smiley: