search

pyronear / pyro-risks

Data science for wildfire risk forecasting and monitoring
https://pyronear.github.io/pyro-risks
Apache License 2.0
25 stars 8 forks source link

doc: type hinting enforcing #55

Closed GHCamille closed 3 years ago

GHCamille commented 3 years ago

This PR enforces type-hinting, as introduced in issue #39 , ensuring that all functions are correctly typed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 (05f4e80) into master (fc9c2b6) will increase coverage by 0.03%. The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   95.93%   95.96%   +0.03%     
==========================================
  Files          27       27              
  Lines        1058     1066       +8     
==========================================
+ Hits         1015     1023       +8     
  Misses         43       43
Flag Coverage Δ
unittests 95.96% <97.61%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyro_risks/pipeline/evaluate.py 100.00% <ø> (ø)
pyro_risks/pipeline/train.py 100.00% <ø> (ø)
pyro_risks/datasets/utils.py 96.99% <75.00%> (ø)
pyro_risks/datasets/ERA5.py 95.50% <100.00%> (ø)
pyro_risks/datasets/era_fwi_viirs.py 93.75% <100.00%> (+0.13%) :arrow_up:
pyro_risks/datasets/fwi.py 98.23% <100.00%> (+0.03%) :arrow_up:
pyro_risks/datasets/queries_api.py 78.57% <100.00%> (ø)
pyro_risks/main.py 97.05% <100.00%> (ø)
pyro_risks/models/pipelines.py 100.00% <100.00%> (ø)
pyro_risks/models/transformers.py 96.62% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc9c2b6...05f4e80. Read the comment docs.

jsakv commented 3 years ago

Thanks for the PR @GHCamille that's awesome 😃 , it looks good to me there only a few changes to make with respect to the code quality standards! No worry these issues were introduced before you refactored the functions but they fall under the scope of this PR!

Here is a cool explanation of the issue raised by Codacity Python Mutable Defaults Are The Source of All Evil

GHCamille commented 3 years ago

Thanks, I honestly didn't understand those errors like it's not even stuff I changed so how come it's not valid 😅 Thank youuu

GHCamille commented 3 years ago

Coming back to it later - Apparent problem with GHCN data that doesn't seem related to the PR

April 25, 2021

A critical systems failure at NCEI is preventing updates to GHCN daily, including the by_year files.
An update will be posted as soon as updates resume.